Review of "Quick Settings Audio Devices Hider" version 3

Details Page Preview

A Gnome Shell extension that allows you to hide selected output/input devices from the Quick Settings audio devices panel. Thanks to it, your Quick Settings panel will list only those devices that you actually use making it easier to quickly switch between them. Check out the https://extensions.gnome.org/extension/6000/quick-settings-audio-devices-renamer/ if you'd rather want to rename some device than hide it.

Extension Homepage
https://github.com/marcinjahn/gnome-quicksettings-audio-devices-hider-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
`SettingsUtils` in prefs.js is not static anymore and; `settings` is local in line 89. So you don't need to dispose and null it out on `close-request`.
marcinjahn posted a review
Thanks for the review. Alright, then I'll remove the window's close-request handler. Could you explain though why there is a difference? I must say that I lack any good understanding of what's going on behind the scenes with memory. What's the difference between: //1: function fillPreferencesWindow(window) { const settings = new SettingsUtils(); } --- //2. function fillPreferencesWindow(window) { const settings = SettingsUtils.getSettings(); } static class SettingsUtils { settings; static getSettings() { if (settings) { this.settings = ExtensionUtils.getSettings(); } return this.settings; } } --- Why in case 1 I do not need to nullify settings, and in the second case I would have to do it? Is it GJS-speciific thing? Btw, do I have to increment the version of my extension each time I upload a new version?
JustPerfection posted a review
The static class in your example saving the `gsettings` in `settings` property. And that's like saving it in global but hiding it inside static class. and the version is auto increment here, It's good to match the ego version and repo version to avoid updates during development.