Review of "Quick Settings Audio Devices Hider" version 5

Details Page Preview

A Gnome Shell extension that allows you to hide selected output/input devices from the Quick Settings audio devices panel. Thanks to it, your Quick Settings panel will list only those devices that you actually use making it easier to quickly switch between them. Check out the https://extensions.gnome.org/extension/6000/quick-settings-audio-devices-renamer/ if you'd rather want to rename some device than hide it.

Extension Homepage
https://github.com/marcinjahn/gnome-quicksettings-audio-devices-hider-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Also disconnect the signal on destroy (line 114 extension.js)
JustPerfection posted a review
btw, what's the reason for not holding all those signals in the same class (line 115 `MixerWrapper`)? I mean you can disconnect them in `unsubscribe` without getting any inputs and that can make the code more readable.
marcinjahn posted a review
Thanks! Missed that.
marcinjahn posted a review
Yeah, it could work also the way you described, I think both ways are valid approaches. A potential downside would be that calling `unsubscribe()` would always unsubscribe everything. It could be that a few subscriptions could be established, and we wouldn't want to drop all of them. It doens't apply in the case of my extension though.