Review of "Quick Settings Audio Devices Hider" version 11

Details Page Preview

A Gnome Shell extension that allows you to hide selected output/input devices from the Quick Settings audio devices panel. Thanks to it, your Quick Settings panel will list only those devices that you actually use making it easier to quickly switch between them. Check out the https://extensions.gnome.org/extension/6000/quick-settings-audio-devices-renamer/ if you'd rather want to rename some device than hide it.

Extension Homepage
https://github.com/marcinjahn/gnome-quicksettings-audio-devices-hider-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version (line 3 prefs.js). 2. Don't use log (line 272 extension.js). Use `console.log()`, `console.warn()`, ... instead.
marcinjahn waiting for author
Hi, thanks for the review. I actually would like to ask about both your requests: 1. What's wrong with using version? 2. Did something change in 45? I used to always rely on `log`.
JustPerfection posted a review
1. We don't want extensions decide what version of Gtk and Gdk to use, because `prefs.js` is not the owner of the prefs window. So, you shouldn't specify the version that has been already specified before by the owner (`extensionPrefsDialog` module). 2. That was a recommendation but yes, GNOME Shell 45 changed the log. Before 45, `log()` and `logError()` were pointing to a custom log which has been removed on 45. Now, on 45, we don't have `logError()` anymore and `log()` is an alias to `console.log()`. Since you are doing log warn (line 411 extension.js), it will be much better to use `console.warn()` there. Also, moving to `console.log()` is preferred since you won't depend on an alias.
marcinjahn posted a review
Alright, thanks for your clarification. Both points should be mentioned on GJS. I am already in the middle of preparing a MR for the 45 porting guide, I found some places where it could be improved. I might add the logging point there as well, I think it was missing.
JustPerfection posted a review
We already replaced all the `log()`s inside gjs.guide with `console.log()`, `console.debug()` and `console.error()`. We actually recommend that in the docs since 42: https://gjs.guide/extensions/development/debugging.html#recommended-practices For version, yes, we don't have that mentioned directly in the docs.
marcinjahn auto- rejected
Auto-rejected because of new version 12 was uploaded