Review of "Media Player Indicator" version 4

Details Page Preview

This extension has been retired. No one has stepped up to take over maintainership, and there have not been any updates in over a year. It should be removed from this site.

Extension Homepage
https://github.com/JasonLG1979/gnome-shell-extensions-mediaplayer/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

gcampax posted a review
Uhm... you added a getSettings, but you're never calling it. Which is good, btw, since GSettings this way cannot be used from e.g.o (you need the SchemaSource dance). Additionally, you need to track the return value of DBus.watch_name and remove all the watches in disable(), or NameOwnerChanged will have side effects after disabling.
eon posted a review
Actually this extension comes from https://github.com/eonpatapon/gnome-shell-extensions-mediaplayer which uses gsettings, so yes I removed only lines that interact with gsettings and leaved some unused parts like getSettings and some consts. Anyway I can removed them if you want Thanks for the notice about DBus.watch_name, I'll fix this