Review "Touch X" version 1 - GNOME Shell Extensions

Review of "Touch X" version 1

Details Page Preview

Touch X

Touch screen ( touchscreen ) accessibility with touch feedback and OSK button. Currently supports multi-touch ripple feedback where the screen is touched. You can enable/disable the touch-feedback and set its size, duration and color as you see fit. Additionally, you can add a toggle button in the panel to force enable or force disable On Screen Keyboard ( OSK ). - When enabled, the OSK will pop up in input fields or with Gnome supported gestures. - When disabled, the OSK will not pop up at all. This works regardless of Touchscreen Accessibility settings and regardless of whether the screen is in touch mode or not ( laptop vs tablet etc ). Update: Multitouch support + Gnome 46 Other extensions: https://extensions.gnome.org/accounts/profile/neuromorph

Extension Homepage: https://github.com/neuromorph/touchx

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
9	Active
8	Active
7	Active
6	Rejected
5	Active
4	Active
3	Rejected
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected July 28, 2023

1. Bad schema file name: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas 2. Disconnect the signal on disable (line 90 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals 3. Also do this in disable: ```js this._settings = null; ``` 4. Why `!!` (line 104 and 109 extension.js)? 5. Please fix the indentation (line 202-209 prefs.js).

x10shun posted a review July 28, 2023

Thank you for your review! And oops, those are some basic things like schema, disconnect signal and indentation that I should have got right first time but missed. I shall be more careful next time. About the double bang '!!', the object can be null, undefined or defined and it was just to ensure conversion to boolean. I did it so since Gnome Shell is doing it that way in locatePointer. However, without '!!' also js does convert and the extension works so I have now removed it. Everything is fixed as suggested, I am uploading the revised version now. Cheers.