Review of "Touch X" version 6

Details Page Preview

Touch screen ( touchscreen ) accessibility with touch feedback and OSK button. Currently supports multi-touch ripple feedback where the screen is touched. You can enable/disable the touch-feedback and set its size, duration and color as you see fit. Additionally, you can add a toggle button in the panel to force enable or force disable On Screen Keyboard ( OSK ). - When enabled, the OSK will pop up in input fields or with Gnome supported gestures. - When disabled, the OSK will not pop up at all. This works regardless of Touchscreen Accessibility settings and regardless of whether the screen is in touch mode or not ( laptop vs tablet etc ). Update: Multitouch support + Gnome 46 Other extensions: https://extensions.gnome.org/accounts/profile/neuromorph

Extension Homepage
https://github.com/neuromorph/touchx

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Everything you have in the constructor (line 15-24 extension.js) should be null out in disable. 2. Anything you create as `this.` should be local to `fillPreferencesWindow()` in prefs.js. because it won't allow garbage collector do its job after window close.
x10shun posted a review
1. Yes, it is set to null in disable or in the this._removePanelOSK() call (function on line 88). Only missing one is _rtime which is an int. I have added a line in disable to null _rtime also. 2. OK. Changed it from `this.` to `const`. Thanks for the review. I will submit updated version.