Review of "Turn off Display" version 1

Details Page Preview

Adds a button to the status menu to turn off the screen. (requires 'xset' and 'xinput' (xorg). On wayland it instead activates the screen saver. So make sure it is configured appropriately.)

Extension Homepage
https://github.com/simonthechipmunk/turnoffdisplay

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Active
10 Inactive
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Meng Zhuo waiting for author
Two common issues: 1. you need to disconnect signal manually 2. spawn needs to make sure that command is existed. Please upload a newer version which fix these.
simonthechipmunk posted a review
> 1. you need to disconnect signal manually fixed in v2. I added that signal later and completely forgot to disconnect it, sorry ;) > 2. spawn needs to make sure that command is existed. I'm not sure how to do that. According to https://mail.gnome.org/archives/commits-list/2011-January/msg04210.html Util.spawn will handle errors on its own and report them via messagetray notification. This works just fine if I set the wrong command on purpose. from js.misc.util : // spawn: // @argv: an argv array // // Runs @argv in the background, handling any errors that occur // when trying to start the program. function spawn(argv) { try { trySpawn(argv); } catch (err) { _handleSpawnError(argv[0], err); } }
simonthechipmunk rejected