Review of "Turn off Display" version 3

Details Page Preview

Adds a button to the status menu to turn off the screen. (requires 'xset' and 'xinput' (xorg). On wayland it instead activates the screen saver. So make sure it is configured appropriately.)

Extension Homepage
https://github.com/simonthechipmunk/turnoffdisplay

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Active
10 Inactive
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

simonthechipmunk posted a review
##changelog Add Signal disconnect Fix coding error in v2 @mengzhuo Concerning Util.spawn: According to https://mail.gnome.org/archives/commits-list/2011-January/msg04210.html Util.spawn will handle errors on its own and report them via messagetray notification. This works just fine if I set the wrong command on purpose. from js.misc.util : // spawn: // @argv: an argv array // // Runs @argv in the background, handling any errors that occur // when trying to start the program. function spawn(argv) { try { trySpawn(argv); } catch (err) { _handleSpawnError(argv[0], err); } } If this is not what you meant, please let me know
Meng Zhuo active
For issue 2: I mean what if your program is not existed on some Linux distributions? Surly the worst case is that your extension crashed and user have no idea what is going on. >> Util.spawn will handle errors on its own and report them via messagetray notification. This works just fine if I set the wrong command on purpose. I can't confirm that on ALL gnome-shell versions, but it's OK for your code to go, so I gonna approve it.
simonthechipmunk rejected
This is what I get for messing with the code, stupid me: My purposely changed command 'xfrset' ended up in the extension.