Review of "Iranian Persian Calendar" version 29

Details Page Preview

تقویم هجری شمسی،قمری و میلادی در میز‌کار گنوم لینوکس قابلیت نمایش اوقات شرعی و پخش اذان درج تعطیلی‌ها و مناسبت‌های رسمی تقویم زبان کاملاً فارسی تاریخ قمری هلالی ایران سازگار با اکثر نسخه‌های گنوم در حال توسعه... Shows Persian + Islamic + Gregorian date in the panel of gnome. It shows: 1- Persian calendar 2- It can show, today is holiday or not! 3- Show notification onDayChanged! 4- Date converter between Persian, Gregorian and Lunar Hijri(Islamic) 5- Show calendar Events. 6- Show PrayTimes and play sound (Azan). Please "rate" here and "star" project in GitHub. Please open an issue in GitHub if you found something or have an idea! گزارش مشکلات: https://github.com/SCR-IR/gnome-shamsi-calendar/issues

Extension Homepage
https://github.com/scr-ir/gnome-shamsi-calendar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. What's the reason for doing that? - line 1-3 calendar.js - line 15-17 extension.js - line 8-10 prefs.js 2. Don't use `export var`, use `export const` instead. 3. Timeouts should be removed on disable (line 336, 340 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 4. Please don't use `print()` in extensions. We have `console.*`: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging 5. If you want path, just use `this.path` (line 545 extension.js). btw, please use `GLib.get_home_dir()` to get the home dir. 6. Where do you uninstall the fonts (line 544 extension.js)? 7. Please remove the unnecessary comments. I see some old code commented that never get used. 8. Please remove line 1579-1585 prefs.js.