Review of "Bluetooth battery indicator" version 35

Details Page Preview

Bluetooth battery indicator

Extension Homepage
https://github.com/MichalW/gnome-bluetooth-battery-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Timeouts should be removed on destroy (line 25 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Don't use spawn command to open prefs. You can use `openPreferences()` (line 41 indicator.js): https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils 3. The source id should be removed/cancelled on disable (line 14 and 32 utils.js). You can read about cancellable sub process here: https://gjs.guide/guides/gio/subprocesses.html#cancellable-processes 4. `lookupByUUID()` is a bad practice when you have access to the instance in the entry point (line 28 settingsWidget.js). You can do this in `prefs.js` instead (dependency injection): ```js new SettingsWidget(this.getSettings()); ```