GNOME Shell Extensions

Review of "Date Menu Formatter" version 11

Details Page Preview

Date Menu Formatter

by mjakubowski

Allows customization of the date display in the panel. Might be especially useful if you're using a horizontal panel which does not at all work well with the default date display. CHANGELOG Version 5: added support for multiple Dash To Panel panels Version 6: fixed issues on earlier Gnome Shell versions Version 10: fixed clock hover style (by bomdia) Version 11: Gnome 45 update by andyholmes@github Version 12: added support for advanced formatters by bomdia@github Version 15: added text alignment choice by bomdia@github

Extension Homepage
https://github.com/marcinjakubowski/date-menu-formatter
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
18 Active
17 Active
16 Active
15 Active
14 Rejected
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create instance of objects in the constructor (line 46 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 2. Also null out in disable: ```js this._formatter = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 4. You cannot use `imports` in 45 extensions. You don't need it anyway (line 33 `prefs.js`).