Review of "Date Menu Formatter" version 12

Details Page Preview

Allows customization of the date display in the panel. Might be especially useful if you're using a horizontal panel which does not at all work well with the default date display. CHANGELOG Version 5: added support for multiple Dash To Panel panels Version 6: fixed issues on earlier Gnome Shell versions Version 10: fixed clock hover style (by bomdia) Version 11: Gnome 45 update by andyholmes@github Version 12: added support for advanced formatters by bomdia@github Version 15: added text alignment choice by bomdia@github Version 16: Gnome 47 support, swatch formatter fixes by bomdia@github

Extension Homepage
https://github.com/marcinjakubowski/date-menu-formatter

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Active
15 Active
14 Rejected
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You forgot to null out `this._formatter` in disable. 2. Don't call functions in global scope (line 46 `extension.js`). 3. You cannot create instance of objects in the constructor (line 21 `formatters/03_swatch.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 4. `lib/luxon.js` is pretty large module. I reviewed that but I recommend to use smaller 3rd party libs next time.