Review of "Power Profile Switcher" version 15

Details Page Preview

Automatically switch between power profiles based on power supply and percentage.

Extension Homepage
https://github.com/eliapasquali/power-profile-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
What's the reason for moving line 40-41 (`extension.js`) to global scope?
eliapasquali posted a review
Those are needed in the global scope to manage the case when someone locks the laptop/log out from the session, because in that case it creates a bad assignment case
JustPerfection rejected
You still need to do this in disable: ```js powerManagerCancellable = null; powerProfilesCancellable = null; ``` and don't use `log()` as mentioned before (version 13 review).