Review "Keyboard Reset" version 1 - GNOME Shell Extensions

Review of "Keyboard Reset" version 1

Details Page Preview

Keyboard Reset

by galets

Reset keyboard to default layout on screensaver activation

Extension Homepage: https://github.com/galets/gnome-keyboard-reset

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
6	Active
5	Active
4	Active
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected May 19, 2024

1. Please remove `Makefile`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Please use a less generic name for the default class you are exporting (for stack trace). 3. Please remove line 72 `extension.js`. Not needed. 4. Also null out in disable: ```js this._dbusImpl = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

JustPerfection posted a review May 19, 2024

5. Please remove `session-modes`: [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed)