Review of "Keyboard Reset" version 3

Details Page Preview

Reset keyboard to default layout on screensaver activation

Extension Homepage
https://github.com/galets/gnome-keyboard-reset

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

galets posted a review
Notes re: previous review 1. init() and code inside of it is necessary, extension does not work without it 2. session-modes in metadata.json can not be removed. This extension specifically needs lock-screen. 3. unnecessary files removed 4. constructor cleaned up, object creation moved into enable()
JustPerfection rejected
> The disable() function MUST have a comment explaining why you are using unlock-dialog. [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes)
galets posted a review
Are we talking about this? ```js disable() { if (this._ss) { Gio.DBus.session.signal_unsubscribe(this._ss); this._ss = null; } if (this._dbusImpl) { this._dbusImpl.unexport(); this._dbusImpl = null; } log(`Disabled`); } ```