Review of "Keyboard Reset" version 5

Details Page Preview

Reset keyboard to default layout on screensaver activation

Extension Homepage
https://github.com/galets/gnome-keyboard-reset

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

galets posted a review
This is not a replacement for version 4, but a separate version for shells 45 and on. Both should be active at the same time
JustPerfection active
Please use `_log()` instead of `log()`.
galets posted a review
> Please use `_log()` instead of `log()`. I'm not quite sure what that means... Are you referring to some specific line, or do you suggest that I should replace all `log(text)` calls across the board with `_log(console.log, text)`?
JustPerfection posted a review
As we mentioned in the docs, you should use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) For example, line 22 `extension.js` is calling `log()` not `_log()`.
galets posted a review
It already does use console.* for logging: ```js function _log(logfunc, ...args) { logfunc(`${Extension.uuid}:`, ...args); } function log(...args) { _log(console.log, ...args); } ``` I think there is a confusion here due to infrastructure providing another log() function with the same name. I shall open an issue to rename the function so that to avoid confusion in future
JustPerfection posted a review
My bad! Missed line 83.