Review of "Timer" version 1

Details Page Preview

A simple GNOME extension that provides a panel timer with an alarm sound notification. Single time units: Use simple time formats like 1h, 1m, or 1s. Multiple time units: Combine units, such as 1h 30m, 1m 25s, or 1h 20m 30s. Repetitions: Use repX (e.g., rep3 for 3 repetitions). Rest time: Use restX with time units (h, m, s) like rest1h, rest1m, rest30s. Combining Units: You can combine the following units to create a custom timer. For example: 2s rep3 rest1m = 2 seconds of work time, 3 repetitions, and 1 minute of rest between repetitions. 1m rep5 rest30s = 1 minute of work time, 5 repetitions, and 30 seconds of rest after each rep.

Extension Homepage
http://github.com/lbgracioso/gnome-timer

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Rejected
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on destroy (line 148 and 174 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) Create `TimerMenu.destroy()` and do `super.destroy()` inside that function at the end. You should destroy on the instance you are creating (line 284 `extenion.js`). Do the same for `TimerButton.destroy()`. 2. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Please remove `Gst` and use this for playing sound: ```js let player = global.display.get_sound_player(); let file = Gio.File.new_for_path('PATH TO THE FILE'); player.play_from_file(file, 'title', null); ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions