Review of "Timer" version 5

Details Page Preview

A simple GNOME extension that provides a panel timer with an alarm sound notification.

Extension Homepage
http://github.com/lbgracioso/gnome-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Rejected
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

lbgracioso posted a review
To make it easier for reviewers, the additions are: Single Time Units: Use simple formats like 1h, 1m, or 1s. Multiple Time Units: Combine units like 1h 30m, 1m 25s, or 1h 20m 30s. Repetitions: Use repX (e.g., rep3 for 3 repetitions). Rest Time: Use restX with time units (s, m, h) like rest30s, rest1m, rest1h. Combining Units Example: 2s rep3 rest1m → 2s work, 3 reps, 1m rest. Sorry, the code is a mess now but I'm not having enough time to refactor everything. As soon as I can it'll be better ;)
JustPerfection rejected
Please remove the timeout (line 150 `extension.js`) before creating a new one since `_playAlarmSound()` can be called multiple times.
lbgracioso posted a review
Made it on v6, thanks for the review!