Review of "Timer" version 2

Details Page Preview

A simple GNOME extension that provides a panel timer with an alarm sound notification. Single time units: Use simple time formats like 1h, 1m, or 1s. Multiple time units: Combine units, such as 1h 30m, 1m 25s, or 1h 20m 30s. Repetitions: Use repX (e.g., rep3 for 3 repetitions). Rest time: Use restX with time units (h, m, s) like rest1h, rest1m, rest30s. Combining Units: You can combine the following units to create a custom timer. For example: 2s rep3 rest1m = 2 seconds of work time, 3 repetitions, and 1 minute of rest between repetitions. 1m rep5 rest30s = 1 minute of work time, 5 repetitions, and 30 seconds of rest after each rep.

Extension Homepage
http://github.com/lbgracioso/gnome-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Rejected
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Set the instance in `this.menu` property (line 292 `extension.js`). 2. Timeout hasn't been addressed here (line 145 `extension.js`).
JustPerfection posted a review
Btw, line 146 `extension.js` will give you fatal error since you are still using `Gst` there.
lbgracioso posted a review
Thanks for the reviews. Btw, your channel is amazing, the reason why I adventured myself creating this plugin ;)
JustPerfection posted a review
Thanks! I'm glad it brought you to the extension community. Let me know if you need any help with the fix.
lbgracioso posted a review
By the way, what do you mean by 1. Set the instance in `this.menu` property (line 292 `extension.js`).? I tried some stuff I found on internet but this is the only one I could make work.
JustPerfection posted a review
I mean you should do this instead: ```js this._menu = new TimerMenu(this, 1.0, St.Side.TOP, this); this.setMenu(this._menu); ``` Don't forget to use `this._menu` instead of `this.menu` in destroy.
lbgracioso posted a review
:facepalm: that's literally what went wrong, I forgot _. There we go, I will upload the new version now. Thanks!