1. Please remove `po` folder: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Please don't use GNOME in uuid, name and schema id: [EGO Review Guidelines: Trademarks](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#copyrights-and-trademarks) 3. You cannot import `Gtk` and `Gdk` to the GNOME Shell process: - line 44 `menu.js` - line 54 `area.js` - line 37 `helper.js` - line 453 `files.js` [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 4. No need to check for older shell versions or if it's needed, it's not a good idea to check the version with string like that. At least parse that to float or int: - line 154, 365, 492, 758, 841 and 910 `menu.js` - line 160 `helper.js` - line 94 `extension.js` [Port Guide 40: Version Checking](https://gjs.guide/extensions/upgrading/gnome-shell-40.html#conditional-imports) 5. You shouldn't use the old `imports` to import a module: - line 44 `menu.js` - line 40 `helper.js` - line 54 `area.js` 6. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 7. You are calling too much `this.getSettings()` in the entry point and all over the other modules. Get the instance once in the entry point and use that instance as dependency injection for other classes needing it. 8. Also null out in disable: ```js this.areaManager = null; this.internalShortcutSettings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 9. `create_toggle()` shouldn't be in the entry point (line 93 `extension.js`). Better to move it to the `Indicator` class. 10. Please mention in the `metadata.json` description that this extension is the fork of the other extension. 11. Timeout should be removed on destroy and also before creating a new one (line 910 `area.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions