Review of "Draw On Gnome" version 6.0 (6)

Details Page Preview

Annotation tool for the GNOME desktop. This extension accesses the clipboard when you press Ctrl+V to paste images. Documentation at: https://daveprowse.github.io/Draw-On-Gnome/ This is a fork of the original DrawOnYourScreen by abakkk.

Extension Homepage
https://github.com/daveprowse/Draw-On-Gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7.0 (7) Active
6.0 (6) Rejected
5.0 (5) Rejected
4.0 (4) Active
1.6 (3) Rejected
1.5 (2) Rejected
1.1 (1) Rejected

Previous Reviews on this Version

dpro42 posted a review
My apologies for the extra upload. I missed an issue that only occurs on GNOME 48. Thought I was testing on 48.5 when actually I was testing on 49.2!!! The new version 6 works on both 48 and 49. Double confirmed. :)
JustPerfection rejected
1. You cannot import `Gdk` to the GNOME Shell process (line 26 `files.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 2. When the clipboard is getting called (line 203 `files.js`)? Asking that since any interaction with clipboard needs direct user action. So users know the clipboard being used. 3. Add to the description that this extension is using clipboard: [EGO Review Guidelines: Clipboard](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#clipboard-access-must-be-declared) 4. Remove `media/gnome-extensions.png`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 5. Remove `persistent-file-name` from `metadata.json`.
dpro42 posted a review
Ah hah. I see the guideline. I thought the ban was on **Gtk widgets**, not Gdk helpers. The function I'm using is a Cairo helper that bridges GdkPixbuf to Cairo. This is so a user can paste images into their drawing. I'm at a loss as to how to solve this without it, but I'll give it another try. If you have any suggestions, I am all ears. Your suggestions were extremely helpful during the version 4 review. Thanks
JustPerfection posted a review
Importing `GdkPixbuf` is okay. We have some extensions using it since there isn't any replacement for it yet.