Review of "Draw On Gnome" version 1.6 (3)

Details Page Preview

Annotation tool for the GNOME desktop. This extension accesses the clipboard when you press Ctrl+V to paste images. Documentation at: https://daveprowse.github.io/Draw-On-Gnome/ This is a fork of the original DrawOnYourScreen by abakkk.

Extension Homepage
https://github.com/daveprowse/Draw-On-Gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7.0 (7) Active
6.0 (6) Rejected
5.0 (5) Rejected
4.0 (4) Active
1.6 (3) Rejected
1.5 (2) Rejected
1.1 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. I recommend to use `destroy()` instead of `_onDestroy()`. Then you can add `super.destroy()` at the end of that function. 2. You have [`.get_child()`](https://gjs-docs.gnome.org/gio20~2.0/gio.settings#method-get_child) that you can use instead (line 53, 61 `prefs.js`). Since you already have `this._settings`, you can use `this._settings.get_child('internal-shortcuts')` and `this._settings.get_child('drawing')` there instead. 3. Please don't store any instance of objects in a property in the default class you are exporting (line 45, 53, 61 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make them local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 4. For `donations`, if you want to use Patreon, just use the user handle: ```json "patreon": "ProwseTech" ``` [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations)