Review of "Time from start (Uptime)" version 1

Details Page Preview

Shows the start time and duration of the system and user operation.

Extension Homepage
https://github.com/pic16f877ccs/Time-from-start

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4.2.0 (9) Active
4.1.0 (8) Active
4.0.1 (7) Active
3.3.0 (6) Active
3.2.2 (5) Active
3.2.1 (4) Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Please remove `session-modes` since you are just removing the indicator in unlock: [EGO Review Guidelines: Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes) 3. Please use a less generic name for the default class you are exporting in both `extension.js` and `prefs.js`. 4. Use `destroy()` not `_destroy()` since that is not a private method (line 124 `extension.js`). 5. `lookupByUUID()` is a bad practice (line 234 `extension.js`). You can send `this` from the entry point (dependency injection). 6. Timeout should be removed on destroy (line 272 and 347 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions