Review of "Time from start (Uptime)" version 2

Details Page Preview

Shows the start time and duration of the system and user operation.

Extension Homepage
https://github.com/pic16f877ccs/Time-from-start

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4.2.0 (9) Active
4.1.0 (8) Active
4.0.1 (7) Active
3.3.0 (6) Active
3.2.2 (5) Active
3.2.1 (4) Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please rename `_clear()` to `destroy()` (line 383 `extension.js`) and do `super.destroy()` at the end of that function. 2. What's the reason for keeping the `session-modes`? When you use unlock session mode, your extension may get disabled and re-enabled on lock multiple times. If the `uptime` is what you want to show to the end user, why not just using spawn command and show that in the panel?
pic16f877ccs posted a review
Using "session modes" allows you to avoid using external commands, easily handle the end of the reminder timer, and send a message to the user "when the screen is locked".
JustPerfection active
That' not what session modes is doing and how it works. As I mentioned before, your extension still will be disabled when user is locking the session and will be re-enabled again. Anyway, I'm going to approve this just for the reminder timer. Please fix the issue I mentioned in #1.