Review of "Time from start (Uptime)" version 4.3.0 (10)

Details Page Preview

Shows the start time and duration of the system and user operation.

Extension Homepage
https://github.com/pic16f877ccs/Time-from-start

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:82
            this._extensionNotificationSource.connect('destroy', _source => {
                this._extensionNotificationSource = null;
            })

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:23
    this._soundFileLister = new SoundFileLister(dirPaths, filesExt)

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:37
        disable() {
            this._sessionModes?.destroy();
            this._sessionModes = null;
        }

All Versions

Version Status
4.3.0 (10) Unreviewed
4.2.0 (9) Active
4.1.0 (8) Active
4.0.1 (7) Active
3.3.0 (6) Active
3.2.2 (5) Active
3.2.1 (4) Rejected
3 Active
2 Active
1 Rejected