Review of "yrtimer" version 2

Details Page Preview

A simple countdown timer for the GNOME top bar

Extension Homepage
https://github.com/yrelay/yrtimer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `icon` from `metadata.json`. Not needed. 2. Remove the gettext import and 29-34 `extension.js`, 30-39 `prefs.js`. You already have the initiated one: [extensionutils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 3. Remove versions from import. 4. `this` is the current extension (line 40 `extension.js`). 5. Avoid using unnecessary try and catch blocks. AFAICS, all of them seem unnecessary. Didn't review all files since there are so many try catch blocks and the fix is going to have a large diff. Please remove all of them and send it again. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
irelay posted a review
Hello GNOME Extensions team, Thanks for the detailed review. I have addressed all points and resubmitted a new package (v3): - Remove icon from metadata.json: done. - Normalize i18n: I removed manual gettext imports and now initialize via ExtensionUtils (initTranslations/gettext) in all modules (including extension.js and prefs.js). - Remove versions from imports: done (gi://…, resource:///… only). - this context in extension.js (line 40): reviewed and fixed where needed (arrow functions/explicit binding). - Avoid unnecessary try/catch: I pruned non‑essential blocks across the codebase, keeping only those around I/O, GSettings, and Shell/i18n calls. Additional cleanups: - Removed Diagnostics page and GSettings keys (debug, show-diagnostics, override-locale), deleted prefs_pages/diag.js, dropped locale override, and stopped writing .last-enable. - Recompiled schemas and purged obsolete i18n entries. - Compatibility: GNOME Shell 45–48 Gettext domain: yrtimer Settings schema: org.gnome.shell.extensions.yrtimer If anything else is needed, I’ll update promptly. Best regards, Hamid