Review of "yrtimer" version 3

Details Page Preview

A simple countdown timer for the GNOME top bar

Extension Homepage
https://github.com/yrelay/yrtimer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Again, avoid unnecessary try and catch blocks. AFAICS, all try and catch blocks should be removed. 2. You shouldn't do legacy when this is 45+ extension: - line 8-15, 46 `core/extensionUtilsCompat.js` - line 28-34 `prefs.js` - line 23-24 `prefs_pages/general.js` - line 18-19 `prefs_pages/panel.js` - line 19-32 `prefs_pages/presets.js` - line 18-20 `prefs_pages/repeat.js` - line 18-19 `prefs_pages/repeat.js` The link for importing gettext properly into the module is given in previous review. 3. Remove everything from the constructor (line 24-28`extension.js`).
irelay posted a review
Thanks for the review. I’ve addressed all three points for v4 : - I removed unnecessary try/catch blocks. - I dropped legacy/compat for 45+ and cleaned remaining spots (`prefs.js`, `prefs_pages/*`), using proper module `gettext` import. - I emptied the constructor in [extension.js](cci:7://file:///home/hamid/~hamid/projets/debian/gnome-shell/extention/yrtimer/work/migration/v2/backup-root/extension.js:0:0-0:0). Additionally, I migrated to ESM; [extension.js](cci:7://file:///home/hamid/~hamid/projets/debian/gnome-shell/extention/yrtimer/work/migration/v2/backup-root/extension.js:0:0-0:0) extends `Extension`, `prefs.js` extends `ExtensionPreferences`, and I use `Extension.lookupByURL(import.meta.url).getSettings()` for settings.