Review of "yrtimer" version 4

Details Page Preview

A simple countdown timer for the GNOME top bar

Extension Homepage
https://github.com/yrelay/yrtimer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Thanks! Please fix these issues and it will be approved: 1. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. Use `this.openPreferences()` from the entry point instead of spawn command (line 135 `ui/indicator.js`): [Extensions Guide: ExtensionBase](https://gjs.guide/extensions/topics/extension.html#methods-2)
irelay posted a review
Thank you for the review! Both issues have been fixed in version 5: 1. ✓ Added `this._settings = null;` in disable() 2. ✓ Replaced spawn commands with `this.openPreferences()`