Review of "Quran Player" version 15

Details Page Preview

Advanced Quran Player with MP3 controls, progress bar, time display, and resume functionality. Features multiple reciters with audio from QuranCentral.com and Archive.org servers.

Extension Homepage
https://github.com/faymaz/quran-player

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 Active
28 Rejected
27 Active
26 Active
25 Active
24 Active
23 Rejected
22 Rejected
21 Active
20 Active
19 Rejected
18 Active
17 Inactive
16 Inactive
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't use sync spawn since that can freeze the shell process (line 2217 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) Also, I don't understand why you need GPU hardware check for an extension that plays audio. What's the reason for freeze? 2. Remove line 2264-2276 `extension.js` since that's for testing purposes.
faymaz posted a review
You're right - this was inappropriate. I added it after user reports of system freezes on older systems, which I thought might be GPU-related. However, I now understand this violates GNOME guidelines. I've removed the entire _checkHardwareCompatibility() method and all related code. and Removed. The _refreshIndicator() method and testing code have been deleted. I've also updated all logging to use log() and logError() instead of console methods. Thank you for the review.