Review of "Quran Player" version 22

Details Page Preview

Advanced Quran Player with MP3 controls, progress bar, time display, and resume functionality. Features multiple reciters with audio from QuranCentral.com and Archive.org servers.

Extension Homepage
https://github.com/faymaz/quran-player

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 Active
28 Rejected
27 Active
26 Active
25 Active
24 Active
23 Rejected
22 Rejected
21 Active
20 Active
19 Rejected
18 Active
17 Inactive
16 Inactive
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You are already including that in the extension package (line 335 `prefs.js`). What's the reason for downloading it remotely? 2. While I believe those remote fetching functions should be removed, if there is a good reason for that, you should call `abort()` on disable (line 477 `extension.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 3. Please make the logs only available on debug mode. You are logging too much and at this point they just spamming the user logs with unnecessary info. 4. Avoid sending large diff since that can make the review process harder and longer.
JustPerfection posted a review
For #2 I meant line 477 `constants.js`.
faymaz posted a review
Thank you for your feedback. I'd like to address each of your points: 1. Regarding remote fetching of custom-reciters.json: The custom-reciters.json is a playlist file that I need to update frequently for two main reasons: - I regularly add new reciters and update the playlist content - Sometimes archive.org removes mp3 files, requiring me to update URLs Rather than releasing a new extension version for every playlist change, I've implemented a caching system that: - Fetches the latest version from GitHub - Caches it locally for offline use - Falls back to the bundled version if both GitHub and cache fail This allows users to get playlist updates without waiting for extension store approval. 2. Regarding Soup.Session.abort() on disable: You're absolutely right. I will add the abort() call in the disable function to properly clean up network sessions. 3. Regarding debug logging: I've implemented a debug mode setting (enable-debug-log in preferences). Now: - Logs only appear when debug mode is enabled - Error messages still display regardless of the setting - This prevents log spam in normal usage 4. Regarding large diffs: I understand. I'll keep future updates more focused and incremental to make the review process smoother.