Review of "Herkul" version 16

Details Page Preview

Prayer times based on Diyanet.gov.tr's schedule and Herkul Radio https://herkul.org/ streaming from RadioKing. Features include prayer time notifications, radio streaming, and multi-city support.

Extension Homepage
https://github.com/faymaz/herkul

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Rejected
8 Rejected
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on destroy and also before creating a new one (line 850 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. Remove `sounds/call_1.mp3` since it is not used anywhere.
JustPerfection posted a review
Also you used the wrong donations value. It should be: ```json "github": "faymaz" ```