Review of "Gotify Notifications" version 2

Details Page Preview

Persistent custom Gotify notifications in GNOME

Extension Homepage
https://github.com/dodog/gotify-notifications

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Can be approved but avoid making the default class you are exporting in `extension.js` that large. It's hard to review for cleanup. 3. Remove line 114-121 `extension.js`. You already have `this.openPreferences()`. 4. Timeout should be removed on disable and also before creating a new one (line 195 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 5. Don't use spawn command for that (line 381 `extension.js`). Use `Soup`: [Port Guide 43: soup3](https://gjs.guide/extensions/upgrading/gnome-shell-43.html#soup3) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions