GNOME Shell Extensions

Review of "Gotify Notifications" version 3

Details Page Preview

Gotify Notifications

by dodog

Persistent custom Gotify notifications in GNOME

Extension Homepage
https://github.com/dodog/gotify-notifications
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Also null out in disable: ```js this._notificationManager = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. Timeout should be removed on destroy (line 102 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)