Review of "Gotify Notifications" version 7

Details Page Preview

Display Gotify notifications in GNOME

Extension Homepage
https://github.com/dodog/gotify-notifications

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 31 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:33
    console.log(`Gotify: Creating custom notification: ${title}`)
  • extension.js:78
    console.log('Gotify: Closing notification')
  • extension.js:176
    console.log('Gotify: Synchronously clearing all notifications')
  • extension.js:204
    console.log('Gotify: All notifications cleared synchronously')
  • extension.js:212
    console.log('Gotify: Clearing all notifications with animation')
  • extension.js:223
    console.log('Gotify: Removing notification')
  • extension.js:292
    console.log('Gotify: Making HTTP request with Soup to:', url)
  • extension.js:319
    console.log('Gotify: HTTP status:', status)
  • extension.js:324
    console.log('Gotify: HTTP request successful')
  • extension.js:370
    console.log('Gotify: Enabling extension...')

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:480
            this._statusIcon = new St.Icon({
                gicon: new Gio.ThemedIcon({ name: 'bell-outline-symbolic' }),
                style_class: 'system-status-icon'
            })

All Versions

Version Status
8 Active
7 Rejected
6 Inactive
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `=== 'function'` and send it again: [GNOME Extension Best Practices: Avoid Unnecessary Checks]()https://gjs.guide/extensions/review-guidelines/best-practices.html#avoid-unnecessary-checks) 2. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages.
JustPerfection posted a review
3. Better to call `this._statusIcon.destroy()` as mentioned in the shexli.
dodog posted a review
Thank you for the review. I tried to fix it all.