Review of "Yet Another Radio" version 2

Details Page Preview

Discover and listen to your favorite internet radio stations using the community driven radio-browser.info API.

Extension Homepage
https://github.com/BuddySirJava/YetAnotherRadio

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Rejected
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Replace line 321-327 `extension.js` with: ```js if (Gst.is_initialized()) { Gst.init(null); } ``` then remove line 497 `extension.js`. 2. Remove line 521-526 `extension.js`. You already have `this.openPreferences()`. 3. Remove versions from imports (line 1-2 `prefs.js`) 4. Remove line 716 `prefs.js`. Already initiated before. 5. No need to use any parameters for `this.getSettings()` if you add this to the `metadata.json`: ```json "settings-schema": "org.gnome.shell.extensions.yetanotherradio", ``` 6. Remove line 4-12 `radioUtils.js`. You already importing gettext correctly in the entry files. 7. Timeout should be removed on disable and before creating a new one (line 129 `radioUtils.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 8. Add to the description that this extension is using `radio-browser.info` services. 9. You should call `abort()` on destroy (line 99 `radioUtils.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) Don't forget to call destroy on the instances of that class. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions