Review of "Yet Another Radio" version 3

Details Page Preview

Discover and listen to your favorite internet radio stations using the community driven radio-browser.info API.

Extension Homepage
https://github.com/BuddySirJava/YetAnotherRadio

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Rejected
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't use `vfunc_dispose` (line 359 `prefs.js`). Use `desotry()` instead. then `super.destroy()` at the end of that function. To call destroy, you can call it on window close reqeust: ```js window.connect('close-request', () => { // clean up here // so you can call destroy of that instance here }); ``` 2. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 3. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations)
BuddySirJava posted a review
Thanks for your time! I'm uploading the new version right away...