GNOME Shell Extensions

Review of "Yet Another Radio" version 17

Details Page Preview

Yet Another Radio

by BuddySirJava

Discover and listen to your favorite internet radio stations using the community driven radio-browser.info API.

Extension Homepage
https://github.com/BuddySirJava/YetAnotherRadio
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • modules/metadataDisplay.js:57 
    St.Clipboard.get_default()

All Versions

Version Status
21 Active
20 Active
19 Active
18 Rejected
17 Rejected
16 Rejected
15 Active
14 Rejected
13 Active
12 Rejected
11 Active
10 Rejected
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

BuddySirJava auto- rejected
Auto-rejected because of new version 18 was uploaded
JustPerfection rejected
1. Please don't use unnecessary try-catch wrappers for something that is not throwing. 2. Selective disable isn't allowed (line 411-412 `modules/hoverScrollingLabel.js`). 3. Timeout isn't removed on disable/destroy (line 290 `modules/metadataDisplay.js`). 4. `_destroyed` is a bad practice. Please remove that. 5. Avoid sending unnecessary AI checks with `?.()`.