Review of "Weather Effect" version 1

Details Page Preview

Adds a weather effect (snow or rain) to your GNOME environment

Extension Homepage
https://github.com/quinsaiz/weather-effect

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't make the default class you are exporting in `extension.js` that large. It makes the review process super hard. You can make it as small as possible (maybe max 30 lines) and move the logic to another class. 2. Timeout should be removed on disable (line 230, 236, 247, `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions