Review of "Weather Effect" version 2.6.1 (4)

Details Page Preview

Adds animated snow and rain effects to GNOME Shell.

Extension Homepage
https://github.com/quinsaiz/weather-effect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1

Shexli found 1 issue that may need reviewer attention.

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
2.6.2 (5) Active
2.6.1 (4) Rejected
2.4.0 (3) Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
What is with checks like 145-149 `lib/QuickSettings.js`? You are doing the same approach in other parts of the code. They all seem like unnecessary code.
quinsaiz posted a review
Thanks! Those checks were unnecessary because the fields exist for the entire object lifetime. I was being overly cautious, but I have reviewed and removed them. Changes to QuickSettings.js have already been made.
JustPerfection rejected
Please remove them and send it again.