Review of "Weather Effect" version 2

Details Page Preview

Adds a weather effect (snow or rain) to your GNOME wallpaper.

Extension Homepage
https://github.com/quinsaiz/weather-effect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
2.4.0 (3) Active
2 Rejected
1 Rejected

Previous Reviews on this Version

quinsaiz posted a review
JustPerfection rejected
1. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 2. Remove unnecessary try-catch wrappers: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` only). 4. In `lib/WeatherEffectController.js` hold all the timeouts in a property. Then loop through them to remove on disable. That way it is easier to review for cleanup. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions