Review of "ClipFlow Pro" version 1.2.9 (4)

Details Page Preview

A modern, powerful clipboard manager for GNOME Shell with intelligent organization, beautiful UI, and comprehensive history management.

Extension Homepage
https://github.com/nickotmazgin/clipflow-pro

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.3.7 45.47 (27) Rejected
1.3.7 (26) Rejected
1.3.6 45.47 (25) Rejected
1.3.6 (24) Rejected
1.3.5 45.47 (23) Rejected
1.3.5 43.44 (22) Rejected
1.3.4 45.47 (21) Rejected
1.3.4 43.44 (20) Rejected
1.3.3 (19) Active
1.3.3 43.44 (18) Rejected
1.3.1 43.44 (17) Rejected
1.3.1 (16) Inactive
1.3.0 (15) Inactive
1.3.0 43.44 (14) Rejected
1.3.0 (13) Rejected
1.3.0 (12) Rejected
1.2.17 (11) Inactive
1.2.16 (10) Inactive
1.2.15 (9) Rejected
1.2.14 (8) Rejected
1.2.13 (7) Inactive
1.2.11 (6) Rejected
1.2.10 (5) Rejected
1.2.9 (4) Rejected
1.2.8 (3) Rejected
1.2.6 (2) Rejected
1.2.3 (1) Rejected

Previous Reviews on this Version

Ghost posted a review
Ported to GNOME Shell 45+ ES Modules (ESM); uses resource:/// and gi:// imports (no legacy imports.*). Preferences integrated via fillPreferencesWindow; header bar (close/minimize) works on 45+. metadata.json lists only tested shells ["45","46","47"]. Packaging is a flat zip with required files (metadata.json, extension.js, prefs.js, stylesheet.css, schemas/ with compiled gschemas, icons/). Version “1.2.9” shown in the About tab (version-name). Minor polish: runtime debug logs and About list now use ASCII (improves locale/terminal compatibility; no functional change). No background services or network activity; all history stored locally under ~/.config/clipflow-pro/. Ported to GNOME Shell 45+ ES Modules; uses resource:/// and gi:// imports (no legacy imports.*). Preferences integrated via fillPreferencesWindow; header bar (close/minimize) works on 45+. metadata.json lists only tested shells ["45","46","47"] per guidance. Packaging is a flat zip with required files (metadata.json, extension.js, prefs.js, stylesheet.css, schemas/ with gschemas.compiled, icons/). About tab displays version “1.2.8”. Warm-poll/retry ensures history populates after login; if empty immediately, it fills after first copy or brief delay.
JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Remove `ExtensionUtils`. Not needed: - line 16, 23 `extension.js` - line 9, 12 `prefs.js` 3. Please use `destroy` not `vfunc_dispose` (line 53 `prefs.js`). Do `super.destroy()` instead. 4. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 5. Remove line 1277-1279 `prefs.js`. Not needed. 6. Avoid using unnecessary try and catch wrapper. Most of them are unnecessary and just making the code base much larger. 7. No need to use `this.initTranslation()` (line 3595 `extension.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 8. Bad practice (line 3593, 3625-3628 `extension.js`). Also falls into selective disable. 9. You made the code base really large just by unnecessary checks like `!== 'function'`. Please remove them and make your code smaller and more readable. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions