Review of "ClipFlow Pro" version 1.3.7 (26)

Details Page Preview

A modern, powerful clipboard manager for GNOME Shell with intelligent organization, beautiful UI, and comprehensive history management.

Extension Homepage
https://github.com/nickotmazgin/clipflow-pro

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.3.7 45.47 (27) Rejected
1.3.7 (26) Rejected
1.3.6 45.47 (25) Rejected
1.3.6 (24) Rejected
1.3.5 45.47 (23) Rejected
1.3.5 43.44 (22) Rejected
1.3.4 45.47 (21) Rejected
1.3.4 43.44 (20) Rejected
1.3.3 (19) Active
1.3.3 43.44 (18) Rejected
1.3.1 43.44 (17) Rejected
1.3.1 (16) Inactive
1.3.0 (15) Inactive
1.3.0 43.44 (14) Rejected
1.3.0 (13) Rejected
1.3.0 (12) Rejected
1.2.17 (11) Inactive
1.2.16 (10) Inactive
1.2.15 (9) Rejected
1.2.14 (8) Rejected
1.2.13 (7) Inactive
1.2.11 (6) Rejected
1.2.10 (5) Rejected
1.2.9 (4) Rejected
1.2.8 (3) Rejected
1.2.6 (2) Rejected
1.2.3 (1) Rejected

Previous Reviews on this Version

Ghost posted a review
Hey Justperfection :), Versions: 43–44 v27 “1.3.7”; 45–47 v32 “1.3.7 45.47” No Gtk in shell process; GNOME Shell APIs only (extension.js) No spawn usage (no external commands); compliant clipboard APIs Async file reads via Gio.File.load_contents_async Logs gated by enable-debug-logs (globalThis.__CFP_DEBUG); removed excessive logs Removed redundant typeof === 'function' guards and most try/catch noise No stylesheet key in metadata.json Prefs: legacy prefs.js for 43–44; ES module prefs for 45–47
andyholmes rejected
Hi, Sorry for the tough time during review, but your submissions involve a rather large amount of unnecessary and confusing code. For example, the many instances like: ``` mi.actor.connect?.('button-release-event', (_actor, event) => {}); ``` Where ClutterActor, being a GObject, will always have a `connect()` function or ``` parent?.remove_child?.(this._icon); ``` Where ClutterActor will always have a `remove_child()`, but `this._icon` may not in fact be a ClutterActor. It seems you are checking for things that are always true, but not checking things that may not be. The function `_obtainClipboardInterface()` is another example of code that could be replaced by a single call to `St.Clipboard.get_default()` Can you please proofread your code for quality and necessity, before submitting for review? We're really getting quite overwhelmed with the amount of extensions that seem to contain generated code.