Review of "P7 Borders" version 8

Details Page Preview

Add window borders to GNOME windows

Extension Homepage
https://github.com/prasannavl/p7-borders-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please don't create instance of objects in the global scope (line 23 `utils.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. GNOME Shell 48+ has the logger. Please remove `utils.js`: [Port Guide 48: logger](https://gjs.guide/extensions/upgrading/gnome-shell-48.html#custom-logger) 3. What's the reason for wrapping with try-catch (line 39 `compat.js`)? 4. Remove unnecessary try-catch wrappers and `typeof` ... `=== "function"`. If AI used here please note we a rule for AI: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) 5. Not a good practice (line 82 `config.js`). Better to put the content into a file inside the extension folder and use that. 6. Avoid making the default class you are exporting that large. It's hard to review for cleanup. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Prasanna Loganathar posted a review
Thanks for the quick review! 1. Resolved. 2. Thanks, missed that. Resolved. 3. 4: Done. My bad on that, was mix up from testing. 5. This one, added a comment on why. This is more of a fallback and the source of truth is from gsettings, so prefer to contain everything inside the config class rather than spread it across multiple files, atleast until it grows outs lot more. 6. Done.