Review of "P7 Borders" version 9

Details Page Preview

Add window borders to GNOME windows

Extension Homepage
https://github.com/prasannavl/p7-borders-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please move line 10 `extension.js` to enable and null it out in disable: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. Unnecessary try-catch wrapper (line 293, 298, 322, 330, 467, 472 `bordermanager.js`). 3. I recommend using `connectObject()`, so you can easily do `disconnectObject()` (line 472 `bordermanager.js`).