Review of "App Icons Taskbar" version 31.2 (38)

Details Page Preview

A taskbar that displays app icons for running applications and favorites on your panel. Features: Add panels to all monitors Intelligent auto-hide (Intellihide) Position panel at top or bottom of monitor Display current weather near the panel clock Show running apps in the panel - Option to isolate by workspace - Option to isolate by monitor Show favorite apps in the panel Customizable panel clock And more!

Extension Homepage
https://gitlab.com/AndrewZaech/aztaskbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-C49-002 error

extensions targeting GNOME 49 must not use removed Clutter action classes

This extension explicitly targets GNOME Shell 49 but still uses removed `Clutter.ClickAction` or `Clutter.TapAction`.

Clutter.ClickAction() and Clutter.TapAction()

  • appIcon.js:121
    new Clutter.ClickAction()

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • desktopIconsIntegration.js:72
    Extension.lookupByURL(import.meta.url)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • windowPreview.js:209
            this.grid = new St.Widget({
                x_expand: true,
                y_expand: true,
                layout_manager: new Clutter.GridLayout({
                    row_spacing: 8,
                    column_spacing: 8,
                }),
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • windowPreview.js:195
            this.actor = new St.ScrollView({
                hscrollbar_policy: St.PolicyType.NEVER,
                vscrollbar_policy: St.PolicyType.NEVER,
                enable_mouse_scrolling: true,
            })
  • windowPreview.js:209
            this.grid = new St.Widget({
                x_expand: true,
                y_expand: true,
                layout_manager: new Clutter.GridLayout({
                    row_spacing: 8,
                    column_spacing: 8,
                }),
            })

All Versions

Version Status
31.2 (38) Unreviewed
31.1 (37) Active
31.0 (36) Active
31.0 (35) Rejected
30.4 (34) Active
30.3 (33) Active
30.2 (32) Active
30.1 (31) Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Rejected
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Inactive