GNOME Shell Extensions

Review of "Shu Zhi" version 37

Details Page Preview

Shu Zhi

by grroot

Generate wallpapers featuring mottos, inspired by jizhi For support, please report issues in time via the Homepage link below rather than the review section below it

Extension Homepage
https://github.com/tuberry/shuzhi
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 2

Shexli found 5 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • color.js:23 
    T.fopen('resource:///org/gnome/shell/extensions/shuzhi/color.tsv').load_contents(null)

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • fubar.js:120 
    x.run_dispose()

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • fubar.js:25 
    Extension.lookupByURL(import.meta.url)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • fubar.js:33 
    St.Clipboard.get_default()
  • fubar.js:34 
    St.Clipboard.get_default()

EGO-A-001 manual_review

extension code must not be minified or obfuscated

File appears obfuscated: 92% of identifiers are 1–2 characters (avg length 1.7).

Code must not be obfuscated

  • prefs.js 
    short identifier ratio: 92%, identifiers scored: 64

All Versions