GNOME Shell Extensions

Review of "NASA APOD Wallpaper Changer" version 49

Details Page Preview

NASA APOD Wallpaper Changer

by Elinvention

Change your wallpaper daily to the NASA's astronomy picture of the day

Extension Homepage
https://github.com/Elinvention/gnome-shell-extension-nasa-apod
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:558 
    this._settings = this.getSettings()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:563 
            this._settings.connect('changed::indicator-position', (s, key) => {
            if (this._indicator) {
                let new_position = s.get_int(key);
                this._indicator.stop();
                this._indicator.destroy();
                this._indicator = new NasaApodIndicator
  • extension.js:187 
    this._settings.connect('changed::api-keys', this._populateKeys.bind(this))
  • extension.js:115 
            this._settings.connect('changed::hide', () => {
            this.visible = !this._settings.get_boolean('hide');
        })
  • extension.js:188 
    this._settings.connect('changed::pinned-background', this._pinnedBackground.bind(this))
  • extension.js:165 
            this.menu.connect('open-state-changed', (menu, isOpen) => {
            if (isOpen)
                this._updateMenuItems();
        })
  • extension.js:514 
            message.connect('got-body-data', (__, size) => {
            bytes_so_far += size;

            if (total_size) {
                let fraction = bytes_so_far / total_size;
                let percent = Math.floor(fraction * 100);
                this.refreshStatusItem.label.set_text(_('Downl
  • extension.js:509 
            message.connect('got-headers', () => {
            total_size = message.get_response_headers().get_content_length();
            Utils.ext_log(`got-headers, total size: ${total_size}B`);
        })

All Versions