GNOME Shell Extensions

Review of "NASA APOD Wallpaper Changer" version 48

Details Page Preview

NASA APOD Wallpaper Changer

by Elinvention

Change your wallpaper daily to the NASA's astronomy picture of the day

Extension Homepage
https://github.com/Elinvention/gnome-shell-extension-nasa-apod
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-I-001 error

deprecated modules must not be imported

Deprecated module `Mainloop` is imported.

Do not use deprecated modules

  • timer.js:1 
    Mainloop = imports.mainloop
  • timer.js:1 
    imports.mainloop

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:188 
    this._settings.connect('changed::api-keys', this._populateKeys.bind(this))
  • extension.js:116 
            this._settings.connect('changed::hide', () => {
            this.visible = !this._settings.get_boolean('hide');
        })
  • extension.js:189 
    this._settings.connect('changed::pinned-background', this._pinnedBackground.bind(this))
  • extension.js:166 
            this.menu.connect('open-state-changed', (menu, isOpen) => {
            if (isOpen)
                this._updateMenuItems();
        })
  • extension.js:513 
            request.connect('got_chunk', (message, chunk) => {
            bytes_so_far += chunk.length;

            if (total_size) {
                let fraction = bytes_so_far / total_size;
                let percent = Math.floor(fraction * 100);
                this.refreshStatusItem.label.set_tex
  • extension.js:507 
            request.connect('got_headers', message => {
            total_size = message.response_headers.get_content_length();
            Utils.ext_log(`Download size: ${total_size}B`);
        })

All Versions