Review of "NASA APOD Wallpaper Changer" version 50

Details Page Preview

Change your wallpaper daily to the NASA's astronomy picture of the day

Extension Homepage
https://github.com/Elinvention/gnome-shell-extension-nasa-apod

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:591
    this._settings = this.getSettings()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:596
            this._settings.connect('changed::indicator-position', (s, key) => {
                if (this._indicator) {
                    let new_position = s.get_int(key);
                    this._indicator.stop();
                    this._indicator.destroy();
                    this._indicator = new NasaApodIndicator
  • extension.js:167
            this._settings.connect('changed::hide', () => {
                this.visible = !this._settings.get_boolean('hide');
            })
  • extension.js:239
    this._settings.connect('changed::pinned-background', this._pinnedBackground.bind(this))
  • extension.js:217
            this.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen)
                    this._updateMenuItems();
            })
  • extension.js:547
            message.connect('got-body-data', (__, size) => {
                bytes_so_far += size;
    
                if (total_size) {
                    let fraction = bytes_so_far / total_size;
                    let percent = Math.floor(fraction * 100);
                    this.refreshStatusItem.label.set_text(_('Downl
  • extension.js:542
            message.connect('got-headers', () => {
                total_size = message.get_response_headers().get_content_length();
                Utils.ext_log(`got-headers, total size: ${total_size}B`);
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
45.1.1 (54) Active
45.1.0 (53) Rejected
43.1.0 (52) Active
40.1.0 (51) Active
50 Active
49 Active
48 Active
47 Active
46 Rejected
45 Rejected
44 Rejected
43 Active
42 Active
41 Active
40 Active
39 Active
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Rejected
28 Rejected
27 Rejected
26 Active
25 Active
24 Active
23 Active
22 Active
21 Inactive
20 Inactive
19 Inactive
18 Inactive
17 Inactive
16 Rejected
15 Inactive
14 Inactive
13 Inactive
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Rejected
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection active