Review of "NASA APOD Wallpaper Changer" version 40.1.0 (51)

Details Page Preview

Change your wallpaper daily to the NASA's astronomy picture of the day

Extension Homepage
https://github.com/Elinvention/gnome-shell-extension-nasa-apod

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-I-001 error

deprecated modules must not be imported

Deprecated module `Mainloop` is imported.

Do not use deprecated modules

  • timer.js:1
    Mainloop = imports.mainloop
  • timer.js:1
    imports.mainloop

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:174
            this._settings.connect('changed::hide', () => {
                this.visible = !this._settings.get_boolean('hide');
            })
  • extension.js:246
    this._settings.connect('changed::pinned-background', this._pinnedBackground.bind(this))
  • extension.js:224
            this.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen)
                    this._updateMenuItems();
            })
  • extension.js:564
            request.connect('got_chunk', (message, chunk) => {
                bytes_so_far += chunk.length;
    
                if (total_size > 0) {
                    let fraction = bytes_so_far / total_size;
                    let percent = Math.floor(fraction * 100);
                    this.refreshStatusItem.label.set
  • extension.js:555
            request.connect('got_headers', message => {
                total_size = message.response_headers.get_content_length();
                if (total_size > 0)
                    Utils.ext_log(`Download size: ${Utils.formatSize(total_size)}`);
                else
                    Utils.ext_log('Download size: 

All Versions

Version Status
45.1.1 (54) Active
45.1.0 (53) Rejected
43.1.0 (52) Active
40.1.0 (51) Active
50 Active
49 Active
48 Active
47 Active
46 Rejected
45 Rejected
44 Rejected
43 Active
42 Active
41 Active
40 Active
39 Active
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Rejected
28 Rejected
27 Rejected
26 Active
25 Active
24 Active
23 Active
22 Active
21 Inactive
20 Inactive
19 Inactive
18 Inactive
17 Inactive
16 Rejected
15 Inactive
14 Inactive
13 Inactive
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Rejected
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection active